Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUMULUS-3847: Remove any remaining ES indexing functions and tests #3897

Merged
merged 21 commits into from
Jan 27, 2025

Conversation

charleshuang80
Copy link
Contributor

…loud Metrics usage

Summary: Summary of changes

Addresses CUMULUS-3847: Remove any remaining ES indexing functions and tests

Changes

  • Detailed list or prose of changes
  • ...

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

Copy link
Contributor

@npauzenga npauzenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple comments. Mostly clarifying questions.

Are there any tests failing/blockers in CI?

@charleshuang80
Copy link
Contributor Author

Had a couple comments. Mostly clarifying questions.

Are there any tests failing/blockers in CI?

Yes, I posted about an aws-client test I'm having issues with in slack.

Copy link
Contributor

@npauzenga npauzenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charleshuang80! This is looking great. I think (pending anything CI uncovers) this should be good to go. I searched the repo and found a couple areas I'm curious about. Notably:

(And other tests that still import es-client) Should those be updated or is that scoped somewhere else?

@charleshuang80
Copy link
Contributor Author

Thanks @charleshuang80! This is looking great. I think (pending anything CI uncovers) this should be good to go. I searched the repo and found a couple areas I'm curious about. Notably:

(And other tests that still import es-client) Should those be updated or is that scoped somewhere else?

I think it depends on the test. A few that utilize the cloud metrics functionality still need it I believe. But this test failed in CI and I've been working on removing the ES stuff and trying to figure out if we can still test the performance. I'll do another search, but if you have other specific examples you think should go or just aren't sure about please let me know.

@charleshuang80
Copy link
Contributor Author

Thanks @charleshuang80! This is looking great. I think (pending anything CI uncovers) this should be good to go. I searched the repo and found a couple areas I'm curious about. Notably:

(And other tests that still import es-client) Should those be updated or is that scoped somewhere else?

So I fixed this file and tested it. Also found a few more references that I removed and tested in the latest commit. There are some references in like granules, test-executions, test-build-operation, and test-granules that I think need to stay for Cloud Metrics. If there are any other locations you think I missed please let me know.

Copy link
Contributor

@npauzenga npauzenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charleshuang80! I think you've got everything that jumps out. If there are areas that still have some ES cruft, we can remove as we find it. The important thing is that the tests pass and all of the core functionality still... functions 😄

@charleshuang80 charleshuang80 merged commit 230bf5b into feature/es-phase-2 Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants